Re: pgsql: Allow pgbench to exit immediately when any client is aborted.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Allow pgbench to exit immediately when any client is aborted.
Date: 2023-08-30 04:16:20
Message-ID: ZO7ClGElQkqnJ6xK@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi Ishii-san,

On Wed, Aug 30, 2023 at 01:05:15AM +0000, Tatsuo Ishii wrote:
> Allow pgbench to exit immediately when any client is aborted.
>
> Previously when client was aborted due to some error during
> benchmarking, other clients continued their run until certain number
> of transactions specified -t was reached or the time specified by -T
> was expired. At the end, the results are printed with caution: "Run
> was aborted; the above results are incomplete" shows.
>
> New option "--exit-on-abort" allows pgbench to exit immediately in
> this case so that users could quickly fix the cause of the failure and
> try again another round of benchmarking.

Buildfarm member koel is saying that this commit was not properly
indented:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2023-08-30%2002%3A19%3A02

Could you address this with a run of pgindent?

After the reindent is itself committed, you should also add the commit
that did the indentation to .git-blame-ignore-revs.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tatsuo Ishii 2023-08-30 04:23:20 Re: pgsql: Allow pgbench to exit immediately when any client is aborted.
Previous Message Nathan Bossart 2023-08-30 01:33:39 pgsql: Fix misuse of PqMsg_Close.