| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Ignore 2PC transaction GIDs in query jumbling |
| Date: | 2023-08-14 23:49:37 |
| Message-ID: | ZNq9kRwWbKzvR+2a@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 14, 2023 at 12:11:13PM +0100, Dagfinn Ilmari Mannsåker wrote:
> As far as I could tell the only thing missing was removing
> DeallocateStmt from the list of unhandled utility statement types (and
> updating comments to match). Updated patch attached.
Hmm. One issue with the patch is that we finish by considering
DEALLOCATE ALL and DEALLOCATE $1 as the same things, compiling the
same query IDs. The difference is made in the Nodes by assigning NULL
to the name but we would now ignore it. Wouldn't it be better to add
an extra field to DeallocateStmt to track separately the named
deallocate queries and ALL in monitoring?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiro Ikeda | 2023-08-15 00:14:15 | Re: Support to define custom wait events for extensions |
| Previous Message | Bruce Momjian | 2023-08-14 23:13:42 | Re: PG 16 draft release notes ready |