Re: ObjectIdGetDatum() missing from SearchSysCache*() callers

On Tue, Jul 18, 2023 at 07:27:02AM +0900, Michael Paquier wrote:
> On Mon, Jul 17, 2023 at 05:33:42PM +0300, Aleksander Alekseev wrote:
> > I can't be 100% sure but it looks like that's all of them. PFA the
> > updated patch v2.
>
> Thanks. Yes, this stuff is easy to miss. I was just grepping for a
> few patterns and missed these two.

Spotted a few more of these things after a second lookup.

One for subscriptions:
src/backend/commands/alter.c:
if (SearchSysCacheExists2(SUBSCRIPTIONNAME, MyDatabaseId,

And two for transforms:
src/backend/utils/cache/lsyscache.c:
tup = SearchSysCache2(TRFTYPELANG, typid, langid);
src/backend/utils/cache/lsyscache.c:
tup = SearchSysCache2(TRFTYPELANG, typid, langid);

And applied the whole. Thanks for looking and spot more of these
inconsistencies!
--
Michael