| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Jacob Champion <jchampion(at)timescale(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs |
| Date: | 2023-07-03 01:17:24 |
| Message-ID: | ZKIhpBreDS7OWnfq@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 30, 2023 at 09:42:13AM +0200, Daniel Gustafsson wrote:
> Agreed, I'd prefer all branches to work the same for this.
Thanks, done this way across all the branches, then.
> Reading the patch, only one thing stood out:
>
> -variable PG_TEST_NOCLEAN is set, data directories will be retained
> -regardless of test status.
> +variable PG_TEST_NOCLEAN is set, those directories will be retained
>
> I would've written "the data directories" instead of "those directories" here.
Adjusted that as well, on top of an extra comment.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2023-07-03 01:45:52 | Re: Skip collecting decoded changes of already-aborted transactions |
| Previous Message | David Rowley | 2023-07-03 00:50:49 | Re: Remove WindowClause PARTITION BY items belonging to redundant pathkeys |