| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Jacob Champion <jchampion(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs |
| Date: | 2023-06-29 00:40:53 |
| Message-ID: | ZJzTFd9Dhd9/xD/K@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 28, 2023 at 10:45:02AM +0200, Peter Eisentraut wrote:
> Right, the usual style is just to check whether an environment variable is
> set to something, not what it is.
>
> Also note that in general not all environment variables are processed by
> Perl, so I would avoid encoding Perl semantics about what is "true" or
> whatever into it.
Agreed. I am not sure that this is worth changing to have
boolean-like checks. Hence, I would also to keep the patch that
checks if the environment variable is defined to enforce the behavior,
without checking for a specific value.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Japin Li | 2023-06-29 00:44:54 | Re: Another incorrect comment for pg_stat_statements |
| Previous Message | Michael Paquier | 2023-06-29 00:19:15 | Re: Another incorrect comment for pg_stat_statements |