Re: BUG #18000: Access method used by matview can be dropped leaving broken matview

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18000: Access method used by matview can be dropped leaving broken matview
Date: 2023-06-27 23:19:15
Message-ID: ZJtuc3bLLGdtk27f@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Tue, Jun 27, 2023 at 10:03:48AM -0700, Nathan Bossart wrote:
> I haven't looked at the patch, but assuming it's not calling
> finish_heap_swap(), it might be okay. But it does seem prudent to check
> that the dependency records are handled correctly.

Double-checking, the patch is able to handle that with an extra
changeDependencyFor() in a code path for relkinds that have no
storage. What the patch does not do it look at pg_depend to see if
the dependency records are stored correctly, and that's something it
had better do.
--
Michael

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Andres Freund 2023-06-28 00:03:52 Re: BUG #18003: FATAL: cannot request additional shared memory outside shmem_request_hook
Previous Message Michael Paquier 2023-06-27 23:11:51 Re: BUG #18000: Access method used by matview can be dropped leaving broken matview