| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, masao(dot)fujii(at)gmail(dot)com, david(dot)christensen(at)crunchydata(dot)com |
| Subject: | Re: Add TLI number to name of files generated by pg_waldump --save-fullpage |
| Date: | 2023-06-27 23:47:21 |
| Message-ID: | ZJt1CYvQduFYnQkF@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 27, 2023 at 04:39:52PM +0900, Kyotaro Horiguchi wrote:
> I meant that the name is structured as
> TLIh-TLIl.<tablespace>.<database>.<relnumber>.<blk>._<fork>, which
> appears to be inconsistent with the comment. (And I'm not sure what
> "TLOID" is..)
Well, to be clear, it should not be TLIh-TLIl but LSNh-LSNl :)
I'm OK with these terms for the comments. This is very internal
anyway so anybody using this feature should know what that means.
And yes, the order of the items is wrong, and I agree that TLOID is a
bit confusing once the TLI is added in the set. I have just used
TBLSPCOID as term in the comment, and adjusted the XXX to be about the
LSN numbers.
Adjusted as per the v2 attached.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-timeline-to-file-names-generated-with-pg_wald.patch | text/x-diff | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Christensen | 2023-06-27 23:58:39 | Re: Add TLI number to name of files generated by pg_waldump --save-fullpage |
| Previous Message | Michael Paquier | 2023-06-27 23:29:19 | Re: Add TLI number to name of files generated by pg_waldump --save-fullpage |