| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, masao(dot)fujii(at)gmail(dot)com, david(dot)christensen(at)crunchydata(dot)com |
| Subject: | Re: Add TLI number to name of files generated by pg_waldump --save-fullpage |
| Date: | 2023-06-27 06:58:38 |
| Message-ID: | ZJqInm5KoY/4rzNl@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 27, 2023 at 03:44:04PM +0900, Kyotaro Horiguchi wrote:
> +# - Timeline number in hex format.
>
> Arn't we reffering to it as "Timeline ID"? (I remember there was a
> discussion about redefining the "timeline ID" to use non-orderable
> IDs. That is, making it non-numbers.)
Using ID is fine by me.
> The file name was "LSNh-LSNl.spcOid.dbOid.relNumber.blk_forkname", but
> the comment in the TAP script read as:
>
> -# XXXXXXXX-XXXXXXXX.DBOID.TLOID.NODEOID.dd_fork with the components being:
>
> which looks wrong. I'm not sure it is a business of this patch, though..
This part is getting changed here anyway, so improving it is fine by
me with the terms you are suggesting for these two 4-byte values in
this comment.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2023-06-27 07:18:11 | Re: Incorrect comment for memset() on pgssHashKey? |
| Previous Message | Nazir Bilal Yavuz | 2023-06-27 06:46:37 | Re: bgwriter doesn't flush WAL stats |