| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Jelte Fennema <me(at)jeltef(dot)nl> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Dmitry Igrishin <dmitigr(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com> |
| Subject: | Re: Deleting prepared statements from libpq. |
| Date: | 2023-06-20 04:18:36 |
| Message-ID: | ZJEonC3cqUAQ+4Lu@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 19, 2023 at 02:49:44PM +0200, Jelte Fennema wrote:
> On Mon, 19 Jun 2023 at 14:17, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>> I am not sure the following two following function comments are right....
>
> They were incorrect indeed. Attached is a patch with those two updated.
The amount of duplication between the describe and close paths
concerns me a bit. Should PQsendClose() and PQsendDescribe() be
merged into a single routine (say PQsendCommand), that uses a message
type for pqPutMsgStart and a queryclass as extra arguments?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2023-06-20 05:12:44 | Re: add non-option reordering to in-tree getopt_long |
| Previous Message | David Rowley | 2023-06-20 04:16:56 | Re: Making empty Bitmapsets always be NULL |