| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, noah(at)leadboat(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: add non-option reordering to in-tree getopt_long |
| Date: | 2023-06-16 01:30:09 |
| Message-ID: | ZIu7IXXNBoYkKl9W@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 15, 2023 at 05:09:59PM -0700, Nathan Bossart wrote:
> On Thu, Jun 15, 2023 at 02:30:34PM +0900, Kyotaro Horiguchi wrote:
>> Hmm, the discussion seems to be based on the assumption that argv[0]
>> can be safely redirected to a different memory location. If that's the
>> case, we can prpbably rearrange the array, even if there's a small
>> window where ps might display a confusing command line, right?
>
> If that's the extent of the breakage, then it seems alright to me.
Okay by me to live with this burden.
> I've attached a new version of the patch that omits the
> POSIXLY_CORRECT stuff.
This looks OK at quick glance, though you may want to document at the
top of getopt_long() the reordering business with the non-options?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2023-06-16 01:35:23 | Re: Fix a typo in rewriteHandler.c |
| Previous Message | YANG Xudong | 2023-06-16 01:28:07 | Re: [PATCH] Add loongarch native checksum implementation. |