Re: Avoid unused value (src/fe_utils/print.c)

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alexander Lakhin <exclusion(at)gmail(dot)com>
Cc: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Avoid unused value (src/fe_utils/print.c)
Date: 2023-06-03 22:42:57
Message-ID: ZHvB8bGGNknkRUIg@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jun 03, 2023 at 03:00:01PM +0300, Alexander Lakhin wrote:
> Clang' scan-build detects 58 errors "Dead assignment", including that one.
> Maybe it would be more sensible to eliminate all errors of this class?

Depends on if this makes any code changed a bit easier to understand I
guess, so that would be a case-by-case analysis. Saying that, the
proposed patch seems right while it makes slightly easier to
understand the footer print part.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabrízio de Royes Mello 2023-06-03 23:42:36 Add test module for Table Access Method
Previous Message Andres Freund 2023-06-03 22:38:24 Re: New Table Access Methods for Multi and Single Inserts