Re: 回复：Fix missing initialization of delayChkptEnd

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: mengjuan(dot)cmj(at)alibaba-inc(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, robertmhaas(at)gmail(dot)com
Subject: Re: 回复：Fix missing initialization of delayChkptEnd
Date: 2023-06-06 11:19:12
Message-ID: ZH8WMLiPja+OKcPt@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 06, 2023 at 03:13:14PM +0900, Kyotaro Horiguchi wrote:
> After a quick check through the 14 tree, then compaing with the
> corresponding parts of 15, it hit me that ProcArrayClearTransaction()
> needs an assertion on the variable. Other than that, the patch looks
> good to me.

Yeah, it feels wrong to check only after delayChkpt in this code
path. I'll look at that tomorrow.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2023-06-06 11:20:40 Re: Do we want a hashset type?
Previous Message Peter Eisentraut 2023-06-06 11:09:00 Re: Simplify pg_collation.collversion for Windows libc