| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru> |
| Cc: | "Fujii(dot)Yuki(at)df(dot)MitsubishiElectric(dot)co(dot)jp" <Fujii(dot)Yuki(at)df(dot)mitsubishielectric(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Ilya Gladyshev <i(dot)gladyshev(at)postgrespro(dot)ru> |
| Subject: | Re: Partial aggregates pushdown |
| Date: | 2023-06-05 16:26:05 |
| Message-ID: | ZH4MnYsI5HQDLBCn@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 5, 2023 at 12:00:27PM +0300, Alexander Pyhalov wrote:
> Note that after these changes "select sum()" will fail for certain cases,
> when remote server version is not the latest. In other cases we tried
> to preserve compatibility. Should we have a switch for a foreign server to
> turn this optimization off? Or do we just state that users
> should use different workarounds if remote server version doesn't match
> local one?
We covered this in April in this and previous emails:
https://www.postgresql.org/message-id/ZDGTza4rovCa%2BN3d%40momjian.us
We don't check the version number for _any_ builtin functions so why
would we need to check for aggregate pushdown? Yes, these will be new
functions in PG 17, we have added functions regularly in major releases
and have never heard reports of problems about that.
This patch will filter pushdown based on the FDW extension whitelist:
https://www.postgresql.org/message-id/20230408041614.wfasmdm46bupbif4%40awork3.anarazel.de
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2023-06-05 16:37:07 | Re: pg_collation.collversion for C.UTF-8 |
| Previous Message | Ranier Vilela | 2023-06-05 16:26:00 | Re: Let's make PostgreSQL multi-threaded |