Re: Autogenerate some wait events code and documentation

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Autogenerate some wait events code and documentation
Date: 2023-05-17 08:14:42
Message-ID: ZGSM8oOpXsXrXy/v@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 17, 2023 at 08:31:53AM +0200, Drouvot, Bertrand wrote:
> Did it that way in V9 attached and the sorting does look like what
> we expect now.

Yes, the order of the items in the individual tables is fine, but this
is still a bit incorrect for the classes? Note that the tables for
the LWLock and Lock are still in reverse order :)

+foreach $waitclass (sort keys %hashwe)

Meaning that you may want to add an extra case-insensitive rule for
the sorting on this line for the SGML docs (also the C part, I guess,
but we care less).

> Agree, V9 does now apply on top of v2-0001-Introducing-WAIT_EVENT_EXTENSION-and-WAIT_EVENT_B.patch
> (just shared in [1]).

If you don't send both patches in the same message the CF bot is going
to complain as v9-0001 is not able to apply independently of the other
patch v2-0001 on the other thread (you could do a git apply -2 -v2,
for example).
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message YANG Xudong 2023-05-17 08:49:05 [PATCH] Add loongarch64 native spin lock.
Previous Message Amit Kapila 2023-05-17 06:47:47 Re: Possible regression setting GUCs on \connect