| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | hysong0101(at)163(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17909: CREATE SCHEMA AUTHORIZATION sch CREATE TABLE foo ( id INT ) will coredump |
| Date: | 2023-04-27 09:31:01 |
| Message-ID: | ZEpA1SgNzEqhgCvA@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, Apr 27, 2023 at 04:59:13PM +0800, Richard Guo wrote:
> In this case the CreateSchemaStmtContext.schemaname is NULL since it is
> not explicitly specified, while the schemaname in the schema element is
> not NULL as it is specified, and setSchemaName cannot copy with such
> situation. Maybe we should check against RoleSpec.rolename in this case
> since that is also the schema's name?
In this case, it is cleaner to just set the schema name in
CreateSchemaStmtContext.schemaname to the role in the RoleSpec if there
is no schema set in the query, because the schema name will have the
same name as the role. That also makes the handling of each element
in schemaElts simpler.
The regression tests cruelly lacks of checks here. This is not a
pattern of CREATE SCHEMA known a lot, but we should do better.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2023-04-27 10:00:00 | Re: BUG #17804: Assertion failed in pg_stat after fetching from pg_stat_database and switching cache->snapshot |
| Previous Message | Daniel Gustafsson | 2023-04-27 09:08:00 | Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files |