| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
| Cc: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Subject: | Re: Remove io prefix from pg_stat_io columns |
| Date: | 2023-04-20 00:42:08 |
| Message-ID: | ZECKYFLp2370a4Kn@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 19, 2023 at 01:54:21PM -0300, Fabrízio de Royes Mello wrote:
> On Wed, Apr 19, 2023 at 1:27 PM Melanie Plageman <melanieplageman(at)gmail(dot)com> wrote:
>> Over in [1], we discussed removing the "io" prefix from the columns
>> "io_context" and "io_object" in pg_stat_io since they seem redundant
>> given the view name
>
> LGTM. All tests passed and were built without warnings.
There are a lot of internal references to both of them mainly around
the buffer manager and the pgstat code, still I agree that the view
feels redundant as currently written, so agreed. It does not seem
like you have missed any references here, from what I can see.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2023-04-20 00:43:15 | Re: Wrong results from Parallel Hash Full Join |
| Previous Message | Justin Pryzby | 2023-04-20 00:41:35 | Re: Wrong results from Parallel Hash Full Join |