From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, gkokolatos(at)pm(dot)me, shiy(dot)fnst(at)fujitsu(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, Rachel Heaton <rachelmheaton(at)gmail(dot)com> |
Subject: | Re: Add LZ4 compression in pg_dump |
Date: | 2023-04-13 00:37:06 |
Message-ID: | ZDdOstf12KHSarmS@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Apr 12, 2023 at 05:52:40PM -0500, Justin Pryzby wrote:
> I don't think you need to call parse_compress_specification(NONE).
> As you wrote it, if zlib is unavailable, there's no parse(NONE) call,
> even for directory and custom formats. And there's no parse(NONE) call
> for plan format when zlib is available.
Yeah, that's not necessary, but I was wondering if it made the code a
bit cleaner, or else the non-zlib path would rely on the default
compression method string.
> The old way had preprocessor #if around both the "if" and "else" - is
> that what you meant?
>
> If you don't insist on calling parse(NONE), the only change is to remove
> the empty #else, which was my original patch.
Removing the empty else has as problem to create an empty if block,
which could be itself a cause of warnings?
> If I were to rewrite the comment, it'd say:
>
> + * When gzip is available, custom and directory formats are compressed by
> + * default
Okay.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2023-04-13 00:53:51 | Re: Clean up hba.c of code freeing regexps |
Previous Message | Melanie Plageman | 2023-04-13 00:31:26 | Re: Wrong results from Parallel Hash Full Join |