Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests
Date: 2023-04-12 22:38:55
Message-ID: ZDcy/12SCzHPFe+r@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 12, 2023 at 03:30:03PM +0300, Aleksander Alekseev wrote:
> Any objections if we remove the tests for "user"?

Based on some rather-recent experience in this area with
COERCE_SQL_SYNTAX, the relationship between the SQL keywords and the
way they can handled internally could be tricky if this area of the
code is touched. So I would choose to keep these tests, FWIW.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message sirisha chamarthi 2023-04-12 22:43:40 Add ps display while waiting for wal in read_local_xlog_page_guts
Previous Message Michael Paquier 2023-04-12 22:23:48 Re: Add LZ4 compression in pg_dump