Re: longfin missing gssapi_ext.h

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Subject: Re: longfin missing gssapi_ext.h
Date: 2023-04-12 01:18:08
Message-ID: ZDYG0GkWQa3uZ8yI@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings,

* Jonathan S. Katz (jkatz(at)postgresql(dot)org) wrote:
> On 4/10/23 11:37 AM, Tom Lane wrote:
> > Stephen Frost <sfrost(at)snowman(dot)net> writes:
> > > * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> > > > IOW, maybe it'd be okay to de-revert 3d4fa227b and add documentation
> > > > saying that --with-gssapi requires MIT Kerberos not Heimdal.
> >
> > > I'd be happy with that and can add the appropriate documentation noting
> > > that we require MIT Kerberos. Presumably the appropriate step at this
> > > point would be to check with the RMT?
> >
> > Yeah, RMT would have final say at this stage.
> >
> > If you pull the trigger, a note to buildfarm-members would be
> > appropriate too, so people will know if they need to remove
> > --with-gssapi from animal configurations.
>
> The RMT discussed this thread and agrees to a "de-revert" of the "Add
> support for Kerberos delegation" patch, provided that:
>
> 1. The appropriate documentation is added AND
> 2. The de-revert occurs no later than 2023-04-15 (upper bound 2023-04-16
> 0:00 AoE).
>
> There's an open item[1] for this task.

Understood. Please find attached the updated patch with changes to the
commit message to indicate that we now require MIT Kerberos, an
additional explicit check for gssapi_ext.h in configure.ac/configure,
along with updated documentation explicitly saying we require MIT
Kerberos for GSSAPI support.

I'll plan to push this tomorrow.

Of course, suggestions/improvements on documentation or anything else
always welcome.

Thanks all!

Stephen

Attachment Content-Type Size
gss_delegation_v11.patch text/x-diff 77.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2023-04-12 01:19:59 Re: Add LZ4 compression in pg_dump
Previous Message Ajay P S 2023-04-12 01:09:41 Regarding Plan tree output(Index/Bitmap Scan)