Re: longfin missing gssapi_ext.h

Greetings,

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Stephen Frost <sfrost(at)snowman(dot)net> writes:
> > I'm guessing it's not really an issue but it does make changing
> > configure a bit annoying on my Ubuntu 22.04, when I run autoconf2.69, I
> > end up with this additional hunk as changed from what our configure
> > currently has.
>
> Not surprising. Thanks to autoconf's long release cycles, individual
> distros often are carrying local patches that affect its output.
> To ensure consistent results across committers, our policy is that you
> should use built-from-upstream-source autoconf not a vendor's version.
> (In principle that could bite us sometime, but it hasn't yet.)

... making me more excited about the idea of getting over to meson.

> Also, you should generally run autoheader after autoconf.
> Checking things here, I notice that pg_config.h.in hasn't been
> updated for the last few gssapi-related commits:
>
> $ git diff
> diff --git a/src/include/pg_config.h.in b/src/include/pg_config.h.in
> index 3665e79..6d572c3 100644
> *** a/src/include/pg_config.h.in
> --- b/src/include/pg_config.h.in
> ***************
> *** 196,201 ****
> --- 196,207 ----
> /* Define to 1 if you have the `getpeerucred' function. */
> #undef HAVE_GETPEERUCRED
>
> + /* Define to 1 if you have the <gssapi_ext.h> header file. */
> + #undef HAVE_GSSAPI_EXT_H
> +
> + /* Define to 1 if you have the <gssapi/gssapi_ext.h> header file. */
> + #undef HAVE_GSSAPI_GSSAPI_EXT_H
> +
> /* Define to 1 if you have the <gssapi/gssapi.h> header file. */
> #undef HAVE_GSSAPI_GSSAPI_H
>
> Shall I push that, or do you want to?

Hrmpf. Sorry about that. Please feel free and thanks for pointing it
out.

Thanks again,

Stephen