| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Ilya Gladyshev <ilya(dot)v(dot)gladyshev(at)gmail(dot)com> |
| Cc: | Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, 李杰(慎追) <adger(dot)lj(at)alibaba-inc(dot)com>, 曾文旌(义从) <wenjing(dot)zwj(at)alibaba-inc(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: CREATE INDEX CONCURRENTLY on partitioned index |
| Date: | 2023-03-26 14:51:25 |
| Message-ID: | ZCBb7flZBr4wtKlK@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Dec 04, 2022 at 01:09:35PM -0600, Justin Pryzby wrote:
> This currently handles partitions with a loop around the whole CIC
> implementation, which means that things like WaitForLockers() happen
> once for each index, the same as REINDEX CONCURRENTLY on a partitioned
> table. Contrast that with ReindexRelationConcurrently(), which handles
> all the indexes on a table in one pass by looping around indexes within
> each phase.
Rebased over the progress reporting fix (27f5c712b).
I added a list of (intermediate) partitioned tables, rather than looping
over the list of inheritors again, to save calling rel_get_relkind().
I think this patch is done.
--
Justin
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Allow-CREATE-INDEX-CONCURRENTLY-on-partitioned-table.patch | text/x-diff | 19.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Janes | 2023-03-26 15:12:48 | awkward cancellation of parallel queries on standby. |
| Previous Message | Hannu Krosing | 2023-03-26 14:43:21 | Time to move pg_test_timing to measure in nanoseconds |