| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Reconcile stats in find_tabstat_entry() and get rid of PgStat_BackendFunctionEntry |
| Date: | 2023-03-22 01:16:12 |
| Message-ID: | ZBpW3NLVT8ygnQp7@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 20, 2023 at 11:57:31AM +0100, Drouvot, Bertrand wrote:
> "Buffer" sounds more appropriate to me, so the attached has been done that way.
This choice is OK for me.
> + <indexterm>
> + <primary>pg_stat_get_xact_blocks_fetched</primary>
> + </indexterm>
> + <function>pg_stat_get_xact_blocks_fetched</function> ( <type>oid</type> )
> + <returnvalue>bigint</returnvalue>
> + </para>
> + <para>
> + Returns the number of buffer fetches for table or index, in the current transaction
This should be "number of buffer fetched", no?
> + </indexterm>
> + <function>pg_stat_get_xact_blocks_hit</function> ( <type>oid</type> )
> + <returnvalue>bigint</returnvalue>
> + </para>
> + <para>
> + Returns the number of buffer hits for table or index, in the current transaction
> + </para></entry>
This one looks OK to me too.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-03-22 01:28:19 | Re: Remove nonmeaningful prefixes in PgStat_* fields |
| Previous Message | Melanie Plageman | 2023-03-22 00:52:52 | Re: Track IO times in pg_stat_io |