From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
Cc: | Daniel Watzinger <daniel(dot)watzinger(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pg_dump/pg_restore: Fix stdin/stdout handling of custom format on Win32 |
Date: | 2023-03-10 01:37:35 |
Message-ID: | ZAqJ38jFIm5LBpYI@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Mar 10, 2023 at 12:12:37AM +0100, Juan José Santamaría Flecha wrote:
> I've broken the patch in two:
> 1. fixes the detection of unseekable files in checkSeek(), using logic that
> hopefully is backpatchable,
> 2. the improvements on file type detection for stat() proposed by the OP.
I am OK with 0002, so I'll try to get this part backpatched down to
where the implementation of stat() has been added. I am not
completely sure that 0001 is the right way forward, though,
particularly with the long-term picture.. In the backend, we have one
caller of fseeko() as of read_binary_file(), so we would never pass
down a pipe to that. However, there could be a risk of some silent
breakages on Windows if some new code relies on that?
There is a total of 11 callers of fseeko() in pg_dump, so rather than
relying on checkSeek() to see if it actually works, I'd like to think
that we should have a central policy to make this code more
bullet-proof in the future.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2023-03-10 01:42:08 | Re: [PATCH] Align GSS and TLS error handling in PQconnectPoll() |
Previous Message | Michael Paquier | 2023-03-10 01:30:15 | Re: Add pg_walinspect function with block info columns |