Re: [PATCH] Align GSS and TLS error handling in PQconnectPoll()

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Jacob Champion <jchampion(at)timescale(dot)com>, Jelte Fennema <me(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Align GSS and TLS error handling in PQconnectPoll()
Date: 2023-03-09 14:51:09
Message-ID: ZAnyXbbrj+fQJfCe@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings,

* Michael Paquier (michael(at)paquier(dot)xyz) wrote:
> On Fri, Feb 17, 2023 at 09:01:43AM -0800, Jacob Champion wrote:
> > On Thu, Feb 16, 2023 at 10:59 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >> I am adding Stephen Frost
> >> in CC to see if he has any comments about all this part of the logic
> >> with gssencmode.
> >
> > Sounds good.
>
> Hearing nothing on this part, perhaps we should just move on and
> adjust the behavior on HEAD? Thats seems like one step in the good
> direction. If this brews right, we could always discuss a backpatch
> at some point, if necessary.
>
> Thoughts from others?

I agree with matching how SSL is handled here and in a review of the
patch proposed didn't see any issues with it. Seems like it's probably
something that should also be back-patched and it doesn't look terribly
risky to do so, is there a specific risk that you see?

Thanks,

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2023-03-09 15:21:38 Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)
Previous Message Nazir Bilal Yavuz 2023-03-09 14:40:13 Re: meson: Non-feature feature options