Re: PATCH: warn about, and deprecate, clear text passwords

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Greg Sabino Mullane <htamfids(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Isaac Morland <isaac(dot)morland(at)gmail(dot)com>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: warn about, and deprecate, clear text passwords
Date: 2025-03-19 15:01:26
Message-ID: Z9rcRn53zhFdgIDc@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 19, 2025 at 10:06:58AM -0400, Robert Haas wrote:
> On Wed, Mar 19, 2025 at 9:24 AM Greg Sabino Mullane <htamfids(at)gmail(dot)com> wrote:
>>> The user has no particular reason to care about the fact that the
>>> password they just typed ended up in the log. That is a concern for the
>>> DBA, not the user, and even if they care about the DBA's feelings, they
>>> only get the warning after it's too late to do otherwise.
>>
>> Can't the same be said about other warnings, esp. md5?
>
> Absolutely. Warnings are sometimes the right thing, but they often
> suck. If something is really a bad idea, "ERROR: bad idea" is vastly
> superior to "WARNING: what you just already did was a bad idea". If we
> don't actually know for sure that it's a bad idea, then it's generally
> better not to emit a warning at all, for fear of log-spamming people
> who know what they're doing.

FWIW I primarily intended the MD5 password warning to alert folks that the
ability to use MD5 passwords will go away at some point in the future. If
they want to continue to use MD5 passwords for now, they are free to do so.
They can even turn off the warnings. One of the main reasons I'm not
totally sold on a clear-text password warning is because we don't have
agreement on removing that ability anytime soon, not to mention Bruce's
point about the debate extending into mid-March.

--
nathan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-03-19 15:31:22 Re: optimize file transfer in pg_upgrade
Previous Message Christoph Berg 2025-03-19 14:58:59 Re: RFC: Additional Directory for Extensions