Re: dsm_registry: Add detach and destroy features

On Fri, Mar 14, 2025 at 10:46:58AM +0900, Sungwoo Chang wrote:
> I also made some fix in GetNamedDSMSegment function where it throws an
> exception if the found entry's size field does not match the user input. It
> looks like dshash_release_lock needs to be called and MemoryContext needs
> to be switched back to the old one.

My expectation is that the error handling takes care of these things. Are
there cases where it does not? In any case, I would expect these errors to
be extremely rare to the point of virtually never happening in practice.

> It's my first time submitting a patch so please let me know if I missed on
> something.

I'm delighted that folks want to expand on this feature, and I'm very
interested in helping. Other things folks have asked for are a view into
the DSM registry [0] and a simple way to allocate a DSA or dshash table
with the DSM registry, all of which seem like good improvements to me.

That being said, we are at the very end of the v18 development cycle, and
most folks are probably busy trying to finish their ongoing projects. So
it may be a while before anyone can give this a meaningful review. Please
be sure to add a commitfest entry [1] so it doesn't get lost.

[0] https://postgr.es/m/4D445D3E-81C5-4135-95BB-D414204A0AB4%40gmail.com
[1] https://commitfest.postgresql.org/

--
nathan