| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: remove open-coded popcount in acl.c |
| Date: | 2025-03-12 18:19:09 |
| Message-ID: | Z9HQHX21PVAK-xea@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 12, 2025 at 05:23:25PM +0100, Álvaro Herrera wrote:
> Strange: this code is not covered by any tests.
>
> https://coverage.postgresql.org/src/backend/utils/adt/acl.c.gcov.html#5533
> https://coverage.postgresql.org/src/backend/utils/adt/acl.c.gcov.html#5438
Huh. Well, it's easy enough to add some basic tests for the grantor
selection machinery. Here's a first try.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Remove-open-coded-popcount-in-acl.c.patch | text/plain | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2025-03-12 18:20:13 | Re: Support NOT VALID / VALIDATE constraint options for named NOT NULL constraints |
| Previous Message | Alena Rybakina | 2025-03-12 18:11:24 | Re: Replace IN VALUES with ANY in WHERE clauses during optimization |