Re: Add regression test checking combinations of (object,backend_type,context) in pg_stat_io

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add regression test checking combinations of (object,backend_type,context) in pg_stat_io
Date: 2025-03-05 12:19:16
Message-ID: Z8hBRJrHqnsgc2An@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 05, 2025 at 07:34:16AM +0000, Bertrand Drouvot wrote:
> That would mean changing the test each time pgstat_tracks_io_object() is
> modified in such a way that the output is changed. That's a good thing as
> the writer will need to double check if the new output makes sense according
> to his changes. So I don't see any reason not to add this test.

Thanks for the review.

> What about adding some extra paranoia like?
>
> SELECT backend_type, object, context FROM pg_stat_io ORDER BY
> backend_type, object, context COLLATE "C";

Why not, to force the ordering.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-03-05 12:28:23 Re: Monitoring gaps in XLogWalRcvWrite() for the WAL receiver
Previous Message David Rowley 2025-03-05 12:07:21 Re: Make tuple deformation faster