Re: Rename some signal and interrupt handling functions for consistency

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Rename some signal and interrupt handling functions for consistency
Date: 2025-03-04 19:38:10
Message-ID: Z8dWoh-j11-isqII@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 04, 2025 at 08:22:02PM +0200, Heikki Linnakangas wrote:
> To make things less confusing, the attached patch renames all the functions
> that are part of the overall signal/interrupt handling system but are *not*
> executed in a signal handler to e.g. ProcessSomething(), rather than
> HandleSomething().

Am I understanding correctly that your plan is to keep the "Handle" prefix
for functions that do run in signal handlers (e.g.,
HandleRecoveryConflictInterrupt())? I don't know how consistent the code
is about that, but it might be nice to establish stricter guidelines for
those, too.

> Any objections?

No objections here. My only concern is that this might break some
third-party code, especially code that uses interrupt.h. I'm not sure it's
worth adding backward-compatibility macros, though.

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2025-03-04 19:46:34 Re: Next commitfest app release is planned for March 18th
Previous Message Álvaro Herrera 2025-03-04 19:32:13 Re: Non-text mode for pg_dumpall