Re: bogus error message for ALTER TABLE ALTER CONSTRAINT

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: bogus error message for ALTER TABLE ALTER CONSTRAINT
Date: 2025-03-04 18:36:21
Message-ID: Z8dIJaGJibtA0l7J@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 04, 2025 at 07:22:22PM +0100, Álvaro Herrera wrote:
> I just discovered that trying to set a foreign key as NO INHERIT in
> ALTER TABLE ALTER CONSTRAINT returns an absurd error message:
>
> create table pk (a int primary key);
> create table fk (a int references pk);
>
> alter table fk alter constraint fk_a_fkey deferrable, alter constraint fk_a_fkey no inherit;
> ERROR: ALTER CONSTRAINT statement constraints cannot be marked NO INHERIT
>
> The explanation is that somebody misunderstood what must be given to
> processCASbits in 2013. The intended message is:
> ERROR: FOREIGN KEY constraints cannot be marked NO INHERIT
>
> Here's the fix along with some additional cleanup.

LGTM

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2025-03-04 18:53:05 Re: making EXPLAIN extensible
Previous Message Álvaro Herrera 2025-03-04 18:22:22 bogus error message for ALTER TABLE ALTER CONSTRAINT