| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Remove wal_[sync|write][_time] from pg_stat_wal and track_wal_io_timing |
| Date: | 2025-02-20 05:37:18 |
| Message-ID: | Z7a_jmpSCjP6HZrh@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 19, 2025 at 09:24:41AM +0000, Bertrand Drouvot wrote:
> That's right but that would mean almost duplicating the pg_stat_wal related
> stuff (because it can't be removed from the doc until the fields are gone). I
> think it's simpler to do it as proposed initially (the end result is the same).
After sleeping on it, I still saw no reason to not apply the changes
from 0002 in wal.sgml to describe that the stats for the writes/fsyncs
are in pg_stat_io rather than pg_stat_wal for the "WAL configuration"
section, so done that. The tags were a bit inconsistent, and I've
managed to miss the.. cough.. s/sync_time/fsync_time/.
0001 was mixing a bit the tags <varname>, <literal> and <function>,
and I've moved that as a paragraph not under the tuning part, to make
it a more general statement with its link to "WAL configuration",
which is a very popular link for pg_stat_io.
Attached is the rest, as of v3-0002.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0002-Remove-wal_-sync-write-_time-from-pg_stat_wal-and.patch | text/x-diff | 24.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2025-02-20 05:46:17 | RE: Inconsistent GUC descriptions |
| Previous Message | Kyotaro Horiguchi | 2025-02-20 05:08:39 | Inconsistent GUC descriptions |