| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Kyotaro Horiguchi' <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Inconsistent GUC descriptions |
| Date: | 2025-02-20 05:46:17 |
| Message-ID: | OSCPR01MB14966F6721C16343DEF95E0EEF5C42@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Horiguchi-san,
I really appreciate your post-commit reviewing.
> However, the existing message for the same situation is written
> without "The value of" at the beginning.
Right. To clarify, max_slot_wal_keep_size has similar check hook which rejects
the upgrade mode, and it starts with "\"%s\" must be set to".
> In addition, all existing
> messages following the "%s must be set to" pattern omit this phrase.
Yes, effective_io_concurrency and maintenance_io_concurrency start with it.
> Therefore, I believe the initial part of the new message should be
> removed for consistency. The attached patch makes this adjustment.
Agreed. I read your patch just in case and looks good to me...
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-02-20 06:11:27 | Re: Introduce XID age and inactive timeout based replication slot invalidation |
| Previous Message | Michael Paquier | 2025-02-20 05:37:18 | Re: Remove wal_[sync|write][_time] from pg_stat_wal and track_wal_io_timing |