| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Inconsistent GUC descriptions |
| Date: | 2025-02-18 05:42:36 |
| Message-ID: | Z7QdzK-iG-wDqqFS@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 18, 2025 at 10:32:40AM +0900, Kyotaro Horiguchi wrote:
> I found that a recent commit (fc069a3a631) introduced an inconsistent
> description for a new GUC variable, enable_self_join_elimination. It
> is written as "Enable removal of unique self-joins.", whereas similar
> variables use "Enables xxx". The attached first patch makes the
> message consistent with the typical wording.
>
> While making this fix, I also noticed four other descriptions written
> as "Enable xxx". The attached second patch corrects them for
> consistency.
Keeping it simple.. I agree that your suggestions and your two
patches make things better, so OK for me. There may be a point in
backpatching as this is user-visible? Perhaps not.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2025-02-18 05:49:51 | Re: Reduce TupleHashEntryData struct size by half |
| Previous Message | Hayato Kuroda (Fujitsu) | 2025-02-18 05:33:05 | ReplicationSlotRelease() crashes when the instance is in the single user mode |