| From: | Christoph Berg <myon(at)debian(dot)org> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg17.3 PQescapeIdentifier() ignores len |
| Date: | 2025-02-15 12:33:54 |
| Message-ID: | Z7CJsvNP95cv7euy@msg.df7cb.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Re: Andres Freund
> > > The fprintf suggests that since 5dc1e42b4 PQescapeIdentifier ignores its len.
> >
> > Ugh, yes. Need something like the attached.
>
> I just pushed this fix, together with an expansion of test_escape.c. With the
> expanded test both uses of strlen() are detected.
FTR, this is also caught by pygresql's regression tests:
test_inserttable_with_dotted_table_name (tests.test_classic_connection.TestInserttable.test_inserttable_with_dotted_table_name) ... ERROR
https://ci.debian.net/packages/p/pygresql/testing/amd64/57838998/
https://qa.debian.org/excuses.php?package=postgresql-17
What's missing in the PG regression tests to see that problem?
Christoph
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2025-02-15 12:37:45 | Re: Virtual generated columns |
| Previous Message | Robins Tharakan | 2025-02-15 11:14:04 | Re: psql: Add tab completion for ALTER USER RESET |