Re: Unneeded volatile qualifier in fmgr.c

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Unneeded volatile qualifier in fmgr.c
Date: 2025-02-12 08:41:34
Message-ID: Z6xevtT9vDJA2tcX@ip-10-97-1-34.eu-west-3.compute.internal
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Wed, Feb 12, 2025 at 04:25:38PM +0800, Julien Rouhaud wrote:
> Hi,
>
> While reading some code in fmgr.c I noticed that the save_nestlevel variable is
> declared as volatile. I'm assuming that's because a long time ago it was
> modified in the PG_TRY / PG_CATCH block but it doesn't look needed anymore.
>
> Trivial patch attached.

Yeah, makes sense to me.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrei Lepikhov 2025-02-12 08:54:33 Re: explain analyze rows=%.0f
Previous Message Julien Rouhaud 2025-02-12 08:25:38 Unneeded volatile qualifier in fmgr.c