Re: Show WAL write and fsync stats in pg_stat_io

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "bharath(dot)rupireddyforpostgres(at)gmail(dot)com" <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: Show WAL write and fsync stats in pg_stat_io
Date: 2025-02-06 08:39:25
Message-ID: Z6R1PQgK-9kS4pFy@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 06, 2025 at 07:32:01AM +0000, Bertrand Drouvot wrote:
> That sounds ok, but I wonder if that's the best appropriate place. I could
> think of the checkpointer test in 029_stats_restart.pl and the startup/standby
> one in one related to standby (030_stats_cleanup_replica.pl?). Though that's
> probably just a matter of taste.

Hmm. Your suggestion of 029_stats_restart.pl is a tempting choice,
indeed, more in line with the fact that we are checking some stats
data. I did not think about that.

Note that I'm OK about using 029 or even 030, as long as both queries
stay together.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chiranmoy.Bhattacharya@fujitsu.com 2025-02-06 08:44:35 Re: [PATCH] SVE popcount support
Previous Message Michael Paquier 2025-02-06 08:35:02 Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible