| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: Test to dump and restore objects left behind by regression |
| Date: | 2025-02-05 06:28:04 |
| Message-ID: | Z6ME9D2oWwNvlmiB@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 27, 2025 at 03:04:55PM +0530, Ashutosh Bapat wrote:
> PFA patch with rebased on the latest HEAD and conflicts fixed.
Thanks for the new patch.
Hmm. I was reading through the patch and there is something that
clearly stands out IMO: the new compare_dumps(). It is in Utils.pm,
and it acts as a wrapper of `diff` with its formalized output format.
It is not really about dumps, but about file comparisons. This should
be renamed compare_files(), with internals adjusted as such, and
reused in all the existing tests. Good idea to use that in
027_stream_regress.pl, actually. I'll go extract that first, to
reduce the presence of `diff` in the whole set of TAP tests.
AdjustDump.pm looks like a fine concept as it stands. I still need to
think more about it. It feels like we don't have the most optimal
interface, though, but perhaps that will be clearer once
compare_dumps() is moved out of the way.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuro Yamada | 2025-02-05 06:28:10 | Re: Showing applied extended statistics in explain Part 2 |
| Previous Message | Masahiko Sawada | 2025-02-05 06:20:51 | Re: Make COPY format extendable: Extract COPY TO format implementations |