add missing PQfinish() calls to vacuumdb

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: add missing PQfinish() calls to vacuumdb
Date: 2025-02-04 16:30:58
Message-ID: Z6JAwqN1I8ljTuXp@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I noticed that vacuum_one_database() doesn't call PQfinish() before
pg_fatal() in a few of the server version checks. I seem to have
unintentionally established this precedent in commit 00d1e88. Michael
claimed to have fixed it before committing [0], but that seems to have been
missed, too. I don't think this is a huge problem, but it does seem nicer
to properly close the connection before exiting. If there are no
objections, I plan to commit and back-patch the attached patch shortly.

[0] https://postgr.es/m/20190108020300.GH22498%40paquier.xyz

--
nathan

Attachment Content-Type Size
v1-0001-vacuumdb-Add-missing-PQfinish-calls-to-vacuum_one.patch text/plain 1.6 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ilyasov Ian 2025-02-04 16:36:02 RE: SIGSEGV, FPE fix in pg_controldata
Previous Message Álvaro Herrera 2025-02-04 16:27:18 Re: Commitfest app release on Feb 17 with many improvements