| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
| Cc: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Remove a unnecessary argument from execute_extension_script() |
| Date: | 2025-02-13 22:32:10 |
| Message-ID: | Z65y6kMZj-7qkaMC@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 13, 2025 at 03:18:51PM -0300, Fabrízio de Royes Mello wrote:
> On Thu, Feb 13, 2025 at 1:02 PM Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
>> The attached patch is to remove a unnecessary argument "schemaOid"
>> from the static function execute_extension_script(). It might have
>> been intended to be used some way initially, but actually this is
>> not used since schemaName is sufficient.
>
> LGTM.
Interesting. This parameter seems to have appeared between v30 [0] and v31
[1] of the original extension patch, and even then it wasn't used. And
from a quick skim, I don't see any discussion about it. I'll plan on
committing this shortly.
[0] https://postgr.es/m/m24o8nhd69.fsf%402ndQuadrant.fr
[1] https://postgr.es/m/4171.1297135840%40sss.pgh.pa.us
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-02-13 22:33:35 | Re: DOCS - inactive_since field readability |
| Previous Message | Nathan Bossart | 2025-02-13 22:18:43 | Re: describe special values in GUC descriptions more consistently |