| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: describe special values in GUC descriptions more consistently |
| Date: | 2025-02-12 22:46:58 |
| Message-ID: | Z60k4qYL7mtPtB3O@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 13, 2025 at 09:02:30AM +1100, Peter Smith wrote:
> One last thing...
>
> - gettext_noop("Zero logs all files. The default is -1 (turning this
> feature off)."),
> + gettext_noop("-1 disables temporary file logs. 0 means log all
> temporary files."),
>
> The first sentence could be ambiguous. E.g. "temporary file logs"
> might be interpreted as meaning logs about temporary files, or about
> temporary logs of files.
>
> I think it should be worded more like the second sentence.
> e.g. "-1 disables logging temporary files. 0 means log all temporary files."
>
> And doing this will be consistent with others you already have:
> + gettext_noop("-1 disables logging statement durations. 0 means log
> all statement durations."),
> + gettext_noop("-1 disables logging autovacuum actions. 0 means log
> all autovacuum actions."),
Good catch. I've fixed that in v5.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Describe-special-values-in-GUC-descriptions-more-.patch | text/plain | 24.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Devulapalli, Raghuveer | 2025-02-12 22:46:59 | RE: Improve CRC32C performance on SSE4.2 |
| Previous Message | Masahiko Sawada | 2025-02-12 22:36:11 | Re: Parallel heap vacuum |