Re: Issues with 2PC at recovery: CLOG lookups and GlobalTransactionData

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Vitaly Davydov <v(dot)davydov(at)postgrespro(dot)ru>
Subject: Re: Issues with 2PC at recovery: CLOG lookups and GlobalTransactionData
Date: 2025-01-31 00:21:53
Message-ID: Z5wXoQ2vGQTqdQHv@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 30, 2025 at 03:36:20PM +0900, Michael Paquier wrote:
> This needs more eyes, so I'll go add an entry in the CF. Patches for
> stable branches are labelled with .txt, to avoid any interference with
> the CF bot.
>
> Thoughts and comments are welcome.

After sleeping over it, I've been able to come up with a split of the
patches for v17 and HEAD: a first one to refactor the 2PC code to
integrate more FullTransactionIds (down to 17) and a second one to
implement a fix. That should make reviews easier. The second patch
for 17 and HEAD matches with the fixes for v13~v16, all are labelled
with a 0002.
--
Michael

Attachment Content-Type Size
v2-0001-Integrate-more-FullTransactionIds-into-2PC-code-17.txt text/plain 42.9 KB
v2-0001-Integrate-more-FullTransactionIds-into-2PC-master.patch text/x-diff 42.6 KB
v2-0002-Fix-issues-with-2PC-file-handling-at-recovery-13.txt text/plain 12.4 KB
v2-0002-Fix-issues-with-2PC-file-handling-at-recovery-14.txt text/plain 12.2 KB
v2-0002-Fix-issues-with-2PC-file-handling-at-recovery-15.txt text/plain 12.1 KB
v2-0002-Fix-issues-with-2PC-file-handling-at-recovery-16.txt text/plain 12.1 KB
v2-0002-Fix-issues-with-2PC-file-handling-at-recovery-17.txt text/plain 13.2 KB
v2-0002-Fix-issues-with-2PC-file-handling-at-recov-master.patch text/x-diff 13.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Peter Smith 2025-01-31 00:19:32 Re: Improve error handling for invalid slots and ensure a same 'inactive_since' time for inactive slots