| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Pass ParseState as down to utility functions. |
| Date: | 2025-01-27 04:57:23 |
| Message-ID: | Z5cSM2GmAyktuGL-@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 27, 2024 at 03:01:58PM +0800, jian he wrote:
> please check attached for changes within ATPrepAlterColumnType
Sorry for the late reply. This is more complete. Two strings are
more complex after doing the coerce_to_target_type(), but honestly I
am not these are worth having a parser_errposition() as they also have
an errhint().
> Maybe we can change to
> errmsg("conflicting NO INHERIT declarations for not-null constraints
> on column \"%s\"", column->colname),
> errhint("specified primary key or identity sequence imply an inherited
> not-null constraint will be created")
>
> what do you think?
Hmm. Not sure that this is an improvement. Will think a bit more
about it.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-01-27 05:00:54 | Re: PGSERVICEFILE as part of a normal connection string |
| Previous Message | Umar Hayat | 2025-01-27 04:40:37 | Re: New process of getting changes into the commitfest app |