| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, jian he <jian(dot)universality(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: attndims, typndims still not enforced, but make the value within a sane threshold |
| Date: | 2025-01-22 19:32:06 |
| Message-ID: | Z5FHtmhRWkLLUQL7@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 21, 2025 at 03:23:31PM -0500, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > I did write a patch in Novemer 2023 to pass the dimension to the layers
> > that needed it, but it was considered too much code compared to its
> > value:
> > https://www.postgresql.org/message-id/ZVwI_ozT8z9MCnIZ@momjian.us
>
> Ah, I'd forgotten that discussion. It looks like the main differences
> between your patch and mine are
>
> (1) you did nothing about getting a nonzero attndims value for views
> and CREATE TABLE AS cases.
>
> (2) you found a way to get pg_dump to preserve attndims, which you
> then also applied to psql's \d.
Yes, I was more focused on perserving the value, rather than computing
zero/non-zero from the data type.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2025-01-22 20:12:30 | Re: Issue with markers in isolation tester? Or not? |
| Previous Message | Joe Conway | 2025-01-22 18:59:56 | Re: Replace current implementations in crypt() and gen_salt() to OpenSSL |