Remove XLogRecGetFullXid() in xlogreader.c?

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Remove XLogRecGetFullXid() in xlogreader.c?
Date: 2025-01-17 05:00:49
Message-ID: Z4nkAQ-lP7fKInbP@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

XLogRecGetFullXid() has been introduced in 67b9b3ca3283 back in 2019,
but as far as I can see this has never been used in the code and this
is used nowhere in the core code.

I have looked at Debian's codesearch and also looked at traces of it
on github without seeing it being used anywhere. Knowing that this
was originally intended for a hypothetical undo log patch back then,
for which no work has been done for years, is there any point in
keeping this function in core?

This issue has been raised on a separate thread, where Noah has sent a
patch to consolidate a bit some epoch calculations for
FullTransactionIds, around here:
https://www.postgresql.org/message-id/Z4i6MbUlZxjK1rRh@paquier.xyz

Removing it would have the benefit to do a bit less refactoring for
some of the work of the other thread, and this removes all traces of
-DFRONTEND in xlogreader.h. ;)

Thoughts or comments?
--
Michael

Attachment Content-Type Size
0001-Remove-XLogRecGetFullXid.patch text/x-diff 2.8 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2025-01-17 05:05:41 Re: Some ExecSeqScan optimizations
Previous Message Shubham Khanna 2025-01-17 04:22:07 Re: Adding a '--two-phase' option to 'pg_createsubscriber' utility.