Re: Fix misuse use of pg_b64_encode function (contrib/postgres_fdw/connection.c)

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org>
Subject: Re: Fix misuse use of pg_b64_encode function (contrib/postgres_fdw/connection.c)
Date: 2025-01-16 05:30:36
Message-ID: Z4iZfEkJ2AOgcfkJ@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 15, 2025 at 10:12:51PM -0300, Ranier Vilela wrote:
> Fix by checking the return and reporting a message to the user,
> in case of failure.

You are right that it is inconsistent to not check the result returned
by these two calls of pg_b64_encode(), as introduced in 761c79508e7f.
Peter?
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2025-01-16 05:38:19 Re: TOAST versus toast
Previous Message Tom Lane 2025-01-16 05:18:38 Re: Make pg_stat_io view count IOs as bytes instead of blocks