| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, dipiets(at)amazon(dot)com |
| Subject: | Re: use a non-locking initial test in TAS_SPIN on AArch64 |
| Date: | 2025-01-10 19:19:55 |
| Message-ID: | Z4Fy23e7iCmZi1Dk@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 10, 2025 at 10:51:40AM -0600, Nathan Bossart wrote:
> Actually, I think I may have just had back luck and/or not warmed things up
> enough. I just re-ran the test a few dozen times, carefully ensuring the
> data was in the cache and periodically alternating between the binary with
> the patch applied and the one without it. The results converged to within
> 1-2% of each other, with the patched version even winning about half the
> time. The averages across all the runs showed a ~0.4% regression, which I
> suspect is well within the noise range.
I went ahead and committed this patch. Please let me know if there are any
remaining concerns.
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Hunter | 2025-01-10 19:22:37 | Re: Possible integer overflow in bringetbitmap() |
| Previous Message | Andres Freund | 2025-01-10 19:07:25 | Re: Reorder shutdown sequence, to flush pgstats later |