| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Small refactoring around vacuum_open_relation |
| Date: | 2025-01-10 04:57:39 |
| Message-ID: | Z4Cow-XLPm4tsn-j@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 09, 2025 at 01:00:06PM +0100, Daniel Gustafsson wrote:
> On 9 Jan 2025, at 11:45, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>> Dunno what others think, this seems useless churn to me.
>
> I agree, I don't see this providing enough value to warrant the changes.
Same here, let's leave things as they are. I've checked the patch and
it's kind of clear what these variables mean in the context of the
code where they are declared.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-01-10 05:54:16 | Re: Infinite loop in XLogPageRead() on standby |
| Previous Message | Michael Paquier | 2025-01-10 04:49:48 | Re: An improvement of ProcessTwoPhaseBuffer logic |