Re: Sort functions with specialized comparators

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: John Naylor <johncnaylorls(at)gmail(dot)com>
Cc: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, David Rowley <dgrowleyml(at)gmail(dot)com>, Антуан Виолин <violin(dot)antuan(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Sort functions with specialized comparators
Date: 2025-01-06 17:47:52
Message-ID: Z3wXSAt7zsziWzKk@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jan 06, 2025 at 05:54:29PM +0700, John Naylor wrote:
> Those functions from common/int.h are probably not good when inlined
> (see comment there).

+1. In fact, I think this comment was added because of the ST_MED3()
function in sort_template.h [0]. IIRC clang handles this just fine, but
gcc does not.

[0] https://postgr.es/m/20240212230423.GA3519%40nathanxps13

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sami Imseih 2025-01-06 17:51:30 Re: Sample rate added to pg_stat_statements
Previous Message Nathan Bossart 2025-01-06 17:35:54 Re: Non-text mode for pg_dumpall