Re: Remove support for OpenSSL *eay32 libs on Windows

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove support for OpenSSL *eay32 libs on Windows
Date: 2024-12-30 01:24:41
Message-ID: Z3H2WfmK6SIj2r9V@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 27, 2024 at 03:09:48PM +0100, Daniel Gustafsson wrote:
> The thread in [0] which adds Meson support for *eay32 OpenSSL library names on
> Windows reminded me that we should remove these from master since we no longer
> support OpenSSL 1.0.2 (which was the final version with those names). Attached
> is a small (as of yet untested on Windows/autoconf) diff removing these names
> from the Makefiles.
>
> [0] CAHrt6656W9OnFomQTHBGYDcM5CKZ7hcgzFt8L+N0ezBZfcN3zA(at)mail(dot)gmail(dot)com

Good idea, looks rather sane to me. I don't have a clear idea about
the WIN32/autoconf combination (sorry!), but I can't really believe
that packagers of OpenSSL on Windows would want the same library name
compatibility, patching upstream to be able to achieve the old naming.
fairywren, hamerkop and drongo use meson. Lorikeet relies on
./configure and builds with OpenSSL 3.0.12, so even there I would hope
that we are in the clear.

Not something I'm planning to care about, just noting that from the
top of OpenSSL master branch (0958f5a5bc47 as of today):
$ git grep eay32
.gitignore:/ms/libeay32.def
.gitignore:/ms/ssleay32.def

They should have no need for these references.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-12-30 03:20:26 Re: Should fix a comment referring to stats collector?
Previous Message Rafael Thofehrn Castro 2024-12-30 01:18:58 Proposal: Progressive explain