Re: Proposal: add new API to stringinfo

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Cc: dgrowleyml(at)gmail(dot)com, gurjeet(at)singh(dot)im, pgsql-hackers(at)postgresql(dot)org, michael(at)paquier(dot)xyz, andrew(at)dunslane(dot)net
Subject: Re: Proposal: add new API to stringinfo
Date: 2025-01-08 17:49:45
Message-ID: Z366uV4ujXT6ioCV@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 07, 2025 at 03:57:57PM +0900, Tatsuo Ishii wrote:
> So the v2 patch version is 1.3787% slower than master. Do you think we
> need further inlining?

If it's not too much work to coax the compiler to do so, then I don't see a
strong reason to avoid it. Granted, there are probably much more expensive
parts of the StringInfo support functions (e.g., palloc()), but these are
hot enough code paths that IMHO it's worth saving whatever cycles we can.

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-01-08 18:12:19 Re: use a non-locking initial test in TAS_SPIN on AArch64
Previous Message Bruce Momjian 2025-01-08 17:40:00 Re: Fwd: Re: A new look at old NFS readdir() problems?